Skip to content

Fix cortex_m test failures from D106339880#19783

Merged
meta-codesync[bot] merged 3 commits into
mainfrom
gh/SS-JIA/545/head
May 26, 2026
Merged

Fix cortex_m test failures from D106339880#19783
meta-codesync[bot] merged 3 commits into
mainfrom
gh/SS-JIA/545/head

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented May 26, 2026

Stack from ghstack (oldest at bottom):

D106339880 introduced two issues that broke modai/test:test_cortex_recipes:

  1. convert_to_cortex_m_pass.py imported CortexMPass from executorch.backends.cortex_m.passes, but the Buck cortex_passes library does not include the package's __init__.py, so the package namespace is empty in Buck builds. Switch to a direct module import from cortex_m_pass.

  2. scratch_buffer_sizes.py was added but never listed in the Buck cortex_passes srcs. Add it so the import resolves at test time.

  3. _CortexMEdgePassManager in modai/recipes/cortex.py only injected exported_program when constructing pass classes. ConvertToCortexMPass now extends CortexMPass, which also requires target_config. Mirror CortexMPassManager.transform() and pass target_config (defaulting to CortexMTargetConfig(cpu=CortexM.M55)) when the pass signature accepts it.

Differential Revision: D106408368

ssjia added 2 commits May 26, 2026 13:29
[ghstack-poisoned]
[ghstack-poisoned]
@SS-JIA SS-JIA requested a review from rascani as a code owner May 26, 2026 20:29
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19783

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 Pending, 1 Unrelated Failure, 1 Unclassified Failure

As of commit acf90c6 with merge base fb3f6eb (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • Check Labels / Check labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    RuntimeError: GraphQL query

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 26, 2026

CLA Missing ID

  • ✅ login: SS-JIA / name: Sicheng Stephen Jia (acf90c6)
  • ❌ The email address for the commit (41c2ff1, be17d15) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

@meta-codesync meta-codesync Bot merged commit 29c3a23 into main May 26, 2026
175 of 189 checks passed
@meta-codesync meta-codesync Bot deleted the gh/SS-JIA/545/head branch May 26, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants