Skip to content

Fix Vulkan compute pipeline crash by checking if VK_EXT_subgroup_size_control is enabled #20762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RanjithRagavan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Vulkan compute pipeline crash by checking if VK_EXT_subgroup_size_control is enabled #20762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68504bd
Fix Vulkan compute pipeline crash by checking if VK_EXT_subgroup_size…
RanjithRagavan Jul 7, 2026
c76ab9a
Merge branch 'main' into fix-vulkan-subgroup-crash
RanjithRagavan Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions backends/vulkan/runtime/vk_api/Adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
* All rights reserved.
Expand Down Expand Up @@ -217,15 +217,25 @@
#endif /* VK_NV_cooperative_matrix2 */

#ifdef VK_EXT_subgroup_size_control
// Only enable the feature struct if the extension was actually requested
// and the feature flag is set on the physical device. The extension itself
// is filtered into enabled_device_extensions by
// find_requested_device_extensions.
// Only enable the feature struct if the extension was actually requested,
// supported, and successfully enabled.
bool subgroup_size_control_extension_enabled = false;
for (const auto& ext : enabled_device_extensions) {
if (strcmp(ext, VK_EXT_SUBGROUP_SIZE_CONTROL_EXTENSION_NAME) == 0) {

@SS-JIA SS-JIA Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add

#include <cstring>

to ensure that strcmp is defined; this should fix the CI failures on this PR!

subgroup_size_control_extension_enabled = true;
break;
}
}

VkPhysicalDeviceSubgroupSizeControlFeaturesEXT subgroup_size_control_features{
physical_device.subgroup_size_control_features};
if (physical_device.supports_subgroup_size_control) {
if (physical_device.supports_subgroup_size_control &&
subgroup_size_control_extension_enabled) {
subgroup_size_control_features.pNext = extension_list_top;
extension_list_top = &subgroup_size_control_features;
} else {
const_cast<PhysicalDevice&>(physical_device).supports_subgroup_size_control = false;

@SS-JIA SS-JIA Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than using const_cast, let's just change the function signature from const PhysicalDevice& physical_device to PhysicalDevice& physical_device (i.e. drop the const).

const_cast<PhysicalDevice&>(physical_device).supports_compute_full_subgroups = false;
}
#endif /* VK_EXT_subgroup_size_control */

Expand Down
Loading