Refactor LoRAFeedForward.forward to use shared lora_call (#20831)#20831
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20831
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit fcf807e with merge base ec52125 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@derekdixu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110890567. |
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
Bot
added
the
release notes: none
billmguo
approved these changes
Jul 10, 2026
Summary: Pull Request resolved: pytorch#20831 Replace inline `_call` closure with `lora_call` from `lora.py`, deduplicating the LoRA dispatch logic. Reviewed By: billmguo Differential Revision: D110890567 Signed-off-by: Di Xu (SWE) <dixu@meta.com>
meta-codesync
Bot
changed the title
derekdixu
force-pushed
the
export-D110890567
branch
from
a488929 to
fcf807e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace inline
_callclosure withlora_callfromlora.py,deduplicating the LoRA dispatch logic.
Reviewed By: billmguo
Differential Revision: D110890567
Signed-off-by: Di Xu (SWE) dixu@meta.com