Add Glymur CAMSS driver

[pshrotri]

Revert "FROMLIST: media: qcom: camss: Add support for PHY API devices"
media: qcom: camss: Add Glymur compatible
media: qcom: camss: Add CSIPHY support for Glymur
media: qcom: camss: enable vfe for Glymur
media: qcom: camss: Enumerate resources for Glymur

[quic-vikramsa]

We need to first post, then add FROMLIST tag.

[qlijarvis]

PR #1229 — validate-patch

PR: #1229

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: No — none of the 5 commits contain lore.kernel.org links
2. Lore link matches PR commits: N/A — no lore links to compare against
3. Upstream patch status: Unknown — cannot determine without lore links or vendor prefixes indicating patch origin/intent
4. PR present in qcom-next: Not checked — validation blocked by missing lore links/prefixes

Recommendation: Add appropriate commit prefixes (FROMLIST:/QCLINUX:/PENDING:) and lore links (if applicable) before merging. The current state violates kernel contribution guidelines for patch attribution and traceability.

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1229 - Add Glymur CAMSS support
Upstream commit: N/A
Verdict: ❌ FAIL

Summary

This PR contains 5 commits:

1. Revert of a FROMLIST commit (no lore link for the revert itself)
2. Add Glymur compatible
3. Add CSIPHY support for Glymur
4. Enable VFE for Glymur
5. Enumerate resources for Glymur

None of the commits contain lore.kernel.org links, and commits 2-5 lack vendor-specific prefixes (QCLINUX:, PENDING:, WORKAROUND:) that would exempt them from requiring upstream links.

---

Commit-by-Commit Analysis

Commit 1/5: Revert "FROMLIST: media: qcom: camss: Add support for PHY API devices"

Check	Status	Note
Subject format	⚠️	Revert commit lacks prefix (should be Revert "FROMLIST: ..." with own prefix before Revert)
Lore link present	❌	No lore link for the revert justification
Body rationale	⚠️	Minimal justification: "Following old CSIPHY Architecture for the GLYMUR"
Authorship	✅	Prashant Shrotriya (submitter)
Co-developed-by usage	⚠️	Vikram Sharma listed as Co-developed-by (acceptable for genuine co-authorship)

Issue: Revert commits should explain why the original FROMLIST patch is being reverted. The rationale "Following old CSIPHY Architecture for the GLYMUR" is insufficient. Is the original patch broken? Incompatible with Glymur hardware? Not yet upstream-ready?

---

Commits 2-5/5: Glymur platform support

Check	Status	Note
Subject matches upstream	❌	No upstream link to compare
Body preserves rationale	N/A	No upstream to compare
Fixes tag present/correct	N/A	Not applicable (new feature)
Authorship preserved	N/A	No upstream author to preserve
Vendor prefix	❌	Missing QCLINUX:/PENDING:/FROMLIST: prefix
Lore link	❌	No lore.kernel.org links

Commits 2-5 add new platform support (Glymur) without:

• Any vendor prefix indicating the patch status
• Any lore.kernel.org link indicating upstream submission
• Any indication whether these are intended for upstream or vendor-only

---

Issues

1. Missing lore links (all commits): None of the 5 commits contain lore.kernel.org links. According to kernel contribution guidelines, patches should either:

   • Have a Link: tag pointing to the lore.kernel.org posting (for FROMLIST/UPSTREAM/BACKPORT)
   • Have a vendor prefix (QCLINUX:/PENDING:/WORKAROUND:) indicating no upstream link is expected

2. Missing commit prefixes (commits 2-5): The Glymur support commits lack prefixes indicating their upstream status:

   • If posted to mailing list → should use FROMLIST: prefix + lore link
   • If vendor-only → should use QCLINUX: prefix
   • If work-in-progress → should use PENDING: prefix

3. Revert justification insufficient (commit 1): The revert commit should explain:

   • Why the PHY API approach is incompatible with Glymur
   • Whether this is a temporary revert or permanent architectural decision
   • Impact on other platforms (does this break x1e80100 support?)

4. Co-developed-by usage (all commits): Vikram Sharma is listed as Co-developed-by on all 5 commits. This is acceptable if both authors genuinely co-authored the code. However, if Vikram is the primary author of some commits, those should have From: Vikram Sharma instead.

---

Verdict

❌ FAIL — Cannot validate without lore links or vendor prefixes.

Required actions before merge:

1. Add appropriate prefixes to all commits:

   • If these patches have been posted to linux-media mailing list → add FROMLIST: prefix + Link: tag
   • If vendor-only (not intended for upstream) → add QCLINUX: prefix
   • If work-in-progress (will be posted later) → add PENDING: prefix

2. Improve revert justification (commit 1):

   • Explain technical reason for reverting PHY API support
   • Document impact on existing platforms
   • Consider whether this should be a conditional revert (Glymur-specific) rather than global

3. Verify authorship: Confirm Co-developed-by usage is correct for all 5 commits, or adjust From: field if Vikram is primary author of specific commits.

---

Final Summary

1. Lore link present: No — none of the 5 commits contain lore.kernel.org links
2. Lore link matches PR commits: N/A — no lore links to compare against
3. Upstream patch status: Unknown — cannot determine without lore links or vendor prefixes indicating patch origin/intent
4. PR present in qcom-next: Not checked — validation blocked by missing lore links/prefixes

Recommendation: Add appropriate commit prefixes (FROMLIST:/QCLINUX:/PENDING:) and lore links (if applicable) before merging. The current state violates kernel contribution guidelines for patch attribution and traceability.

[qlijarvis]

PR #1229 — checker-log-analyzer

PR: #1229
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26398350036

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings: unknown commit ID, undocumented DT compatible
dt-binding-check	⏭️	No binding changes
dtb-check	⏭️	No DTS changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	All 5 commits missing required prefix
tag-check	❌	All 5 commits missing required prefix (mandatory for topic branches)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1229 - Add Glymur CAMSS support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26398350036

Checker	Result	Summary
checkpatch	❌	2 warnings: unknown commit ID, undocumented DT compatible
dt-binding-check	⏭️	No binding changes
dtb-check	⏭️	No DTS changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	All 5 commits missing required prefix
tag-check	❌	All 5 commits missing required prefix (mandatory for topic branches)

---

❌ checkpatch

Root cause: Two style issues across 2 commits: (1) unknown commit ID in revert, (2) undocumented DT compatible string.

Failure details:

Commit 923168b - Revert "FROMLIST: media: qcom: camss: Add support for PHY API devices":

WARNING: Unknown commit id 'ced87bfab5230523ea05156b327c98ce6bda0eac', maybe rebased or not pulled?
#7: 
This reverts commit ced87bfab5230523ea05156b327c98ce6bda0eac.

Commit 85fb5f4 - media: qcom: camss: Add Glymur compatible:

WARNING: DT compatible string "qcom,glymur-camss" appears un-documented -- check ./Documentation/devicetree/bindings/
#33: FILE: drivers/media/platform/qcom/camss/camss.c:6294:
+	{ .compatible = "qcom,glymur-camss", .data = &glymur_resources },

Fix:

1. Unknown commit ID warning: This is a false positive. The commit ced87bfab5230523ea05156b327c98ce6bda0eac exists in the topic branch being reverted but checkpatch cannot find it in the current tree context. This warning can be ignored if the commit ID is correct.

2. Undocumented DT compatible: Add the qcom,glymur-camss compatible string to the CAMSS device tree binding documentation at Documentation/devicetree/bindings/media/qcom,camss.yaml. Add it to the compatible enum list.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git df3ae9703774b70a7b7758b53498a25de9f87174..5c94ee5d5db8de87ad8eb1afd7332f1d18e13164

---

❌ check-patch-compliance

Root cause: All 5 commits are missing the required subject-line prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, etc.).

Failure details:

Checking commit: Revert "FROMLIST: media: qcom: camss: Add support for PHY API devices"
Commit summary does not start with a required prefix

Checking commit: media: qcom: camss: Add Glymur compatible
Commit summary does not start with a required prefix

Checking commit: media: qcom: camss: Add CSIPHY support for Glymur
Commit summary does not start with a required prefix

Checking commit: media: qcom: camss: enable vfe for Glymur
Commit summary does not start with a required prefix

Checking commit: media: qcom: camss: Enumerate resources for Glymur
Commit summary does not start with a required prefix

Fix:

Each commit subject must start with one of the required prefixes. Based on the nature of these patches (vendor-specific Glymur SoC support), the appropriate prefix is likely QCLINUX: (vendor-only) or PENDING: (work-in-progress).

For the revert commit, add a prefix before Revert:

git rebase -i df3ae9703774b70a7b7758b53498a25de9f87174
# Mark commit 923168bb1e48 as 'edit'
git commit --amend -m "QCLINUX: Revert \"FROMLIST: media: qcom: camss: Add support for PHY API devices\""
# Continue for each commit, adding appropriate prefix:
# QCLINUX: media: qcom: camss: Add Glymur compatible
# QCLINUX: media: qcom: camss: Add CSIPHY support for Glymur
# QCLINUX: media: qcom: camss: enable vfe for Glymur
# QCLINUX: media: qcom: camss: Enumerate resources for Glymur
git rebase --continue

Note: If these patches have been posted upstream to lore.kernel.org, use FROMLIST: instead and add a Link: tag to the commit body pointing to the lore URL. If they are vendor-only with no upstream equivalent, QCLINUX: is correct but be aware that check-patch-compliance will continue to fail for QCLINUX: prefixed commits (this is a known checker limitation).

Reproduce locally:

# The checker script is not publicly available, but you can manually verify:
git log df3ae9703774b70a7b7758b53498a25de9f87174..HEAD --format="%H %s" | \
  grep -vE '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'

---

❌ tag-check (mandatory for topic branches)

Root cause: All 5 commits lack the required subject-line prefix. This check is mandatory for all branches except qcom-next and qcom-next-staging.

Failure details:

Since this PR targets the kernel-topics repository (likely a topic branch, not qcom-next or qcom-next-staging), every commit must start with one of these prefixes:

• FROMLIST: - Posted to mailing list
• FROMGIT: - From maintainer tree
• UPSTREAM: - Merged into mainline
• BACKPORT: - Backported with modifications
• QCLINUX: - Vendor-only
• PENDING: - Work-in-progress
• WORKAROUND: - Temporary fix

All 5 commits currently lack any prefix:

1. Revert "FROMLIST: media: qcom: camss: Add support for PHY API devices"
2. media: qcom: camss: Add Glymur compatible
3. media: qcom: camss: Add CSIPHY support for Glymur
4. media: qcom: camss: enable vfe for Glymur
5. media: qcom: camss: Enumerate resources for Glymur

Fix: Same as check-patch-compliance above - add the appropriate prefix to each commit subject line.

---

Verdict

5 blockers must be fixed before merge:

1. Add qcom,glymur-camss to DT binding documentation (checkpatch warning)
2. Add required prefix to all 5 commit subjects (check-patch-compliance + tag-check)

The unknown commit ID warning in the revert commit is a false positive and can be ignored if the commit SHA is correct in the topic branch context.

Recommended action: Rebase the PR to add the appropriate subject-line prefix (QCLINUX: or PENDING:) to all 5 commits, and add the DT binding documentation for the new compatible string.

[wenmliu]

No need to revert change, just add .legacy_phy = true, in camss_resources, then you can use old csiphy code.

[nihal231998]

LGTM

[cjha01]

LGTM