Skip to content

Move pytest options to pyproject.toml#1279

Open
mhucka wants to merge 5 commits intoquantumlib:mainfrom
mhucka:move-pytest-options-to-pyproject
Open

Move pytest options to pyproject.toml#1279
mhucka wants to merge 5 commits intoquantumlib:mainfrom
mhucka:move-pytest-options-to-pyproject

Conversation

@mhucka
Copy link
Copy Markdown
Contributor

@mhucka mhucka commented Apr 23, 2026

In addition to being the more modern approach, this lets us start to consolidate tool options into a single well-known location, and also lets us simplify the check scripts.

One of the PRs that will resolve #1268.

mhucka added 3 commits April 23, 2026 19:34
In addition to being the more modern approach, this lets us start to
consolidate tool options into a single well-known locadtion instead of
burying them in a nonstandard location like `dev_tools/conf/`.
Now that the options are in pyproject.toml, the explicit argument is no
longer necessary.
@mhucka
Copy link
Copy Markdown
Contributor Author

mhucka commented Apr 23, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the pytest configuration from a standalone dev_tools/conf/pytest.ini file into the pyproject.toml file under the [tool.pytest.ini_options] section. Correspondingly, the check/pytest script has been updated to remove the explicit configuration file flag. I have no feedback to provide.

@mhucka mhucka marked this pull request as ready for review April 23, 2026 19:56
@mhucka mhucka requested review from fdmalone and mpharrigan April 23, 2026 19:57
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the pytest configuration from a standalone .ini file to the pyproject.toml file. Specifically, it moves test markers and warning filters to the [tool.pytest.ini_options] section and updates the check/pytest script to remove the explicit configuration file flag, allowing pytest to use the default configuration discovery. I have no feedback to provide.

@mhucka mhucka enabled auto-merge April 23, 2026 21:07
@mhucka mhucka added area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics area/health Involves code and/or project health labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics area/health Involves code and/or project health

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move tool configuration settings into pyproject.toml

1 participant