Move mypy options to pyproject.toml#1280
Merged
mhucka merged 7 commits intoquantumlib:mainfrom Apr 24, 2026
Merged
Conversation
In addition to being the more modern approach, this lets us start to consolidate tool options into a single well-known locadtion instead of burying them in a nonstandard location like `dev_tools/conf/`.
Now that the options are in pyproject.toml, the explicit argument is no longer necessary.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the mypy configuration from a standalone .ini file to pyproject.toml and updates the check/mypy script to use the default configuration. A review comment highlights that the global ignore_errors = true setting, though existing previously, should be addressed as it disables effective type checking.
mhucka
added
area/devops
pavoljuhas
reviewed
Apr 23, 2026
pavoljuhas
approved these changes
Apr 23, 2026
Contributor
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM with a tiny suggestion.
Safer for long-term maintenance.
pavoljuhas
approved these changes
Apr 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to being the more modern approach, this lets us start to consolidate tool options into a single well-known locadtion instead of burying them in a nonstandard location like
dev_tools/conf/.One of the PRs that will resolve #1268.