Skip to content

Increase the delay between PubChem retries again#1285

Merged
mhucka merged 7 commits intoquantumlib:mainfrom
mhucka:increase-delay-again
Apr 24, 2026
Merged

Increase the delay between PubChem retries again#1285
mhucka merged 7 commits intoquantumlib:mainfrom
mhucka:increase-delay-again

Conversation

@mhucka
Copy link
Copy Markdown
Contributor

@mhucka mhucka commented Apr 24, 2026

The tests still fail during merges due to a server busy error. This increases the delay even more.

mhucka and others added 7 commits April 24, 2026 04:25
The live API test still fails in CI. It ends up failing 4 times in a
row:

```
test_geometry_from_pubchem_live_api failed on attempt 1! Retrying!
...
test_geometry_from_pubchem_live_api failed on attempt 2! Retrying!
...
test_geometry_from_pubchem_live_api failed on attempt 3! Retrying!
...
test_geometry_from_pubchem_live_api failed after 4 attempts!
```

Let's increase the retry delay.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mhucka mhucka marked this pull request as ready for review April 24, 2026 06:16
@mhucka mhucka merged commit eebf875 into quantumlib:main Apr 24, 2026
18 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the flaky test configuration for the PubChem live API test by increasing the retry count and initial delay. A review comment suggests re-adding the backoff parameter to ensure an exponential retry strategy, which is more effective for managing server congestion.

Comment thread src/openfermion/chem/pubchem_test.py
@mhucka mhucka deleted the increase-delay-again branch April 24, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant