Pin CI dependencies via uv lock without re-resolving pyproject.toml - #1929
Pin CI dependencies via uv lock without re-resolving pyproject.toml#1929rosspeili wants to merge 3 commits into
Conversation
Use --no-install-project plus editable --no-deps install in CI workflows, and --no-emit-project in export-from-uv-lock.sh. Update contributor and dev dependency docs accordingly. Fixes quantumlib#1843.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and scripts for managing Python dependencies using uv. Specifically, it documents a two-step installation process (uv sync --no-install-project followed by uv pip install --no-deps -e .) across several files to ensure dependencies are strictly resolved from uv.lock. It also updates export-from-uv-lock.sh to use the --no-emit-project flag to prevent unpinned dependency resolution. I have no feedback to provide.
|
Thanks for the review @mpharrigan, trimmed the rules, CONTRIBUTING, and README per your nits and kept the CI/export changes and the two-step install notes in |
2 participants
Use --no-install-project plus editable --no-deps install in CI workflows, and --no-emit-project in export-from-uv-lock.sh, and also updated contributor and dev dependency docs to reflect the changes.
Fixes #1843.