Fix tinytex install silently ignoring extraction failures#14357
Merged
Conversation
Check the return value of unzip() during TinyTeX installation. When extraction fails (e.g., tar xf on a .tar.xz without xz-utils), the installer now throws a clear error instead of proceeding to move non-existent files and producing a confusing lstat/NotFound error. For .tar.xz archives, the error message includes a hint to install xz-utils. Also add xz-utils to .deb Recommends and xz to .rpm Recommends since TinyTeX now ships .tar.xz as the preferred format. Fixes #14304
The .tar.xz format is also used on macOS, where tar has built-in xz support. Only show the xz-utils installation hint on Linux where the tool may genuinely be missing. Adjust tests to verify platform-specific behavior.
Ensure the catch block verifies the error is actually an extraction
failure ("Failed to extract") before checking xz-utils hint
presence, preventing a false pass if install() unexpectedly succeeds.
cderv
added a commit
that referenced
this pull request
Apr 15, 2026
…14360) Backport from #14357. `quarto install tinytex` silently succeeded when archive extraction failed, leaving users with a broken TinyTeX installation. Check the `unzip()` return value and surface a clear error message, including an xz-utils install hint on Linux for `.tar.xz` archives. Add `xz-utils`/`xz` to `.deb`/`.rpm` Recommends so the dependency is available on fresh installs. Fixes #14304
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
quarto install tinytexdownloads a.tar.xzarchive on a system without xz-utils,tar xffails but the installer shows[✓] Unzippingand proceeds to move files from a non-existent directory, producing a confusinglstat/NotFounderror.Root Cause
The
unzip()call intinytex.tsdiscards theProcessResultreturn value. Other callers (extension install,quarto use template,quarto use brand) all checkresult.success— the TinyTeX installer was the exception.This became a visible problem after #14181 made
.tar.xzthe preferred format for Linux and macOS TinyTeX packages. Unlike.tar.gz(gzip is universal),.tar.xzrequires xz-utils which isn't installed on minimal/container images.Fix
Check the
unzip()return value and throw on failure with a clear error message. For.tar.xzarchives, the message includes a hint to install xz-utils.Also add
xz-utilsto.debRecommends andxzto.rpmRecommends, since TinyTeX now ships.tar.xzas the preferred archive format.Fixes #14304