regulator: edatec-panel-regulator: Fix backlight power state restoration#7457
Merged
Conversation
The previous implementation only wrote to the REG_PWR register when bl_power was explicitly 1 or 4. This caused a bug where transitioning from a low-power state (1 or 4) back to the normal backlight state (0) would not trigger a register update, leaving the panel in an incorrect power state. Signed-off-by: FrankLeeEDA <Fli@edatec.cn>
Contributor
|
That looks OK to me, assuming it does what you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation only wrote to the REG_PWR register when bl_power was explicitly 1 or 4. This caused a bug where transitioning from a low-power state (1 or 4) back to the normal backlight state (0) would not trigger a register update, leaving the panel in an incorrect power state.
Introduce the 'bl_power_last' field in struct ed_regulator to cache the last written power state. Update the status only when the new power state differs from the cached one. This ensures that any change in the backlight power state is correctly propagated to the hardware.