Skip to content

fix(sdk): skip the header for PAT detail error and not-found states - #1899

Merged
rohilsurana merged 1 commit into
mainfrom
fix/pat-detail-skip-header-on-error
Aug 21, 2026
Merged

fix(sdk): skip the header for PAT detail error and not-found states#1899
rohilsurana merged 1 commit into
mainfrom
fix/pat-detail-skip-header-on-error

Conversation

@rohilsurana

Copy link
Copy Markdown
Member

What

Follow-up to #1895. In the PAT detail view, the error and not-found states rendered the ViewHeader (breadcrumb row). This removes it so those states show only the EmptyState, which matches how the PAT list view hides its header for its empty state.

Why

Review feedback on #1895: "ViewHeader should be skipped for error states." That PR was merged before the change landed, so this carries it forward.

Testing

Loaded a cross-org / invalid token URL in the local client-demo: the not-found state now shows just the empty state (heading, message, and action button) with no breadcrumb header. A valid in-org token still renders the normal detail view with its header.

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview Aug 21, 2026 5:36am

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 95012f5f-1518-4bb6-bf46-c31fe75d2655

📥 Commits

Reviewing files that changed from the base of the PR and between 4fb6f25 and 1f681d9.

📒 Files selected for processing (1)
  • web/sdk/client/views/pat/pat-details-view.tsx
💤 Files with no reviewable changes (1)
  • web/sdk/client/views/pat/pat-details-view.tsx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Simplified the PAT error and not-found screen by removing the unnecessary breadcrumb header.
    • The relevant empty-state message now appears directly as the primary content.

Walkthrough

The PAT details view no longer renders a breadcrumb ViewHeader in error states. The existing not-found and unexpected-error EmptyState content remains.

Changes

PAT error state

Layer / File(s) Summary
Remove error-state header
web/sdk/client/views/pat/pat-details-view.tsx
The error state removes the “Personal access token” breadcrumb ViewHeader. The existing EmptyState content remains.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1f681

This is a narrowly scoped presentation change that removes the breadcrumb header only from PAT error and not-found states while preserving the normal detail view; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32451182070

Coverage remained the same at 48.804%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 40101
Covered Lines: 19571
Line Coverage: 48.8%
Coverage Strength: 15.73 hits per line

💛 - Coveralls

@rohilsurana
rohilsurana marked this pull request as ready for review August 21, 2026 05:50
@rohilsurana
rohilsurana merged commit 670a8fe into main Aug 21, 2026
8 checks passed
@rohilsurana
rohilsurana deleted the fix/pat-detail-skip-header-on-error branch August 21, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants