fix(sdk): skip the header for PAT detail error and not-found states - #1899
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PAT details view no longer renders a breadcrumb ChangesPAT error state
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a narrowly scoped presentation change that removes the breadcrumb header only from PAT error and not-found states while preserving the normal detail view; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 32451182070Coverage remained the same at 48.804%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
What
Follow-up to #1895. In the PAT detail view, the error and not-found states rendered the
ViewHeader(breadcrumb row). This removes it so those states show only theEmptyState, which matches how the PAT list view hides its header for its empty state.Why
Review feedback on #1895: "ViewHeader should be skipped for error states." That PR was merged before the change landed, so this carries it forward.
Testing
Loaded a cross-org / invalid token URL in the local client-demo: the not-found state now shows just the empty state (heading, message, and action button) with no breadcrumb header. A valid in-org token still renders the normal detail view with its header.