Skip to content

chore(store): remove the orphaned blob store and its gocloud.dev dependency - #1900

Draft
rohilsurana wants to merge 1 commit into
mainfrom
chore/remove-orphaned-blob-store
Draft

chore(store): remove the orphaned blob store and its gocloud.dev dependency#1900
rohilsurana wants to merge 1 commit into
mainfrom
chore/remove-orphaned-blob-store

Conversation

@rohilsurana

Copy link
Copy Markdown
Member

What

Delete the internal/store/blob package and drop the gocloud.dev dependency.

Why

internal/store/blob had two users: the boot-time resources-config schema loader and the billing plans loader. Both were removed when those flows moved to the declarative reconcile flow (#1767 and #1870). What was left, blob.go and plans/sample.yaml, has no importers, and gocloud.dev was used only by this package.

Verified before removing:

  • rg "internal/store/blob" returns nothing outside the package itself.
  • rg "gocloud.dev" -g '*.go' returns nothing outside blob.go.

Result

  • Removed internal/store/blob/blob.go and internal/store/blob/plans/sample.yaml.
  • go mod tidy dropped gocloud.dev and its transitive Google Cloud tree (cloud.google.com/go/*, google.golang.org/api, s2a-go, google/wire, and others). go.sum shrank by about 2400 lines.
  • go build ./... and go vet ./internal/store/... ./cmd/... both pass.

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview Aug 21, 2026 6:53am

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6899f928-1230-4826-ba5c-801ab3d55757

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32456196339

Coverage increased (+0.08%) to 48.886%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 40034
Covered Lines: 19571
Line Coverage: 48.89%
Coverage Strength: 15.76 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants