RDK-60738: Remove Sensitive StringFrom Open Source#358
Open
aruna007 wants to merge 1 commit into
Open
Conversation
Reason for change: Remove Sensitive String (Pattern055) From Open Source Test Procedure: Tested the tasks locally Risks: Low Signed-off-by: Aruna_Appikatla@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a sensitive-looking string used as the temporary SSH identity filename in WAN/LAN sync scripts by replacing it with a new non-sensitive identifier.
Changes:
- Update
PEER_COMM_IDin WAN DNS sync script to use/tmp/interchip. - Update
PEER_COMM_IDin LAN DHCP lease sync script to use/tmp/interchip.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/scripts/init/service.d/service_wan/dns_sync.sh | Replaces the peer communication identity file path used for scp-based DNS syncing. |
| source/scripts/init/service.d/service_lan/dhcp_lease_sync.sh | Replaces the peer communication identity file path used for scp-based DHCP lease syncing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #ATOM_RPC_IP=`cat /etc/device.properties | grep ATOM_ARPING_IP | cut -f 2 -d"="` | ||
| LAN_IP=`syscfg get lan_ipaddr` | ||
| PEER_COMM_ID="/tmp/elxrretyt.swr" | ||
| PEER_COMM_ID="/tmp/interchip" |
| DHCP_LEASE_FILE_ATOM="/nvram/dnsmasq.leases" | ||
| DHCP_LEASE_FILE_ATOM_TMP="/tmp/dnsmasq.leases" | ||
| PEER_COMM_ID="/tmp/elxrretyt.swr" | ||
| PEER_COMM_ID="/tmp/interchip" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove Sensitive String (Pattern055) From Open Source
Test Procedure: Tested the tasks locally
Risks: Low
Signed-off-by: Aruna_Appikatla@comcast.com