Skip to content

fix: show subtitles on submenus - #1219

Draft
juliusmarminge wants to merge 2 commits into
react-native-menu:masterfrom
juliusmarminge:agent/submenu-subtitles-and-identifiers
Draft

fix: show subtitles on submenus#1219
juliusmarminge wants to merge 2 commits into
react-native-menu:masterfrom
juliusmarminge:agent/submenu-subtitles-and-identifiers

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Aug 10, 2026

Copy link
Copy Markdown

Overview

iOS currently applies subtitle only when an action becomes a leaf UIAction. An action with subactions becomes a UIMenu, so its subtitle is silently dropped.

This assigns UIMenu.subtitle on iOS 15+ and derives a stable UIMenu.Identifier from the action id for navigable submenus. Stable identifiers let UIKit match submenu nodes during in-place menu updates without returning the user to the root menu. Inline sections do not navigate, so they keep UIKit's stock identifier behavior.

Related to #536, which reported missing iOS subtitles. Leaf action subtitles are supported today, but the submenu path remained unhandled.

Companion to #1220, which refreshes presented menus in place and relies on these stable identifiers to preserve the current submenu level.

Test Plan

  • yarn lint
  • yarn typescript
  • yarn test --runInBand
  • Generated the new-architecture iOS example workspace with CocoaPods/codegen
  • Built the iOS example for a generic simulator with the new architecture enabled

Generated with OpenAI Codex (GPT-5) in T3 Code.

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant