Skip to content

Update apps for SceneDelegate support (#57717) - #57717

Open
cipolleschi wants to merge 4 commits into
react:mainfrom
cipolleschi:export-D113758227
Open

Update apps for SceneDelegate support (#57717)#57717
cipolleschi wants to merge 4 commits into
react:mainfrom
cipolleschi:export-D113758227

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary:

Update the RNTester and HelloWorld JS layers for SceneDelegate-based window resizing and app lifecycle behavior.

Changelog:
[iOS][Changed] - Update RNTester and HelloWorld for SceneDelegate lifecycle behavior

Test Plan:

  • Verify Dimensions updates after resizing the RNTester window.
  • Verify the HelloWorld app renders with the SceneDelegate bootstrap.
  • arc f
  • arc lint

Reviewed By: javache

Differential Revision: D113758227

Pulled By: cipolleschi

Summary:
Update `RCTDeviceInfo` to refresh cached dimensions when the interface frame, orientation, or content size changes.

This provides fresh values from native `getConstants()` after dimension changes.

Changelog:
[iOS][Fixed] - Refresh `DeviceInfo` constants after interface dimension changes

Reviewed By: javache

Differential Revision: D113401534

Pulled By: cipolleschi
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026
@meta-codesync

meta-codesync Bot commented Jul 28, 2026

Copy link
Copy Markdown

@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113758227.

@github-actions

Copy link
Copy Markdown

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Jul 28, 2026
Summary:
Pull Request resolved: react#57717

Update the RNTester and HelloWorld JS layers for SceneDelegate-based window resizing and app lifecycle behavior.

Changelog:
[iOS][Changed] - Update RNTester and HelloWorld for SceneDelegate lifecycle behavior

Test Plan:
- Verify Dimensions updates after resizing the RNTester window.
- Verify the HelloWorld app renders with the SceneDelegate bootstrap.
- `arc f`
- `arc lint`

Reviewed By: javache

Differential Revision: D113758227

Pulled By: cipolleschi
@meta-codesync meta-codesync Bot changed the title Update apps for SceneDelegate support Update apps for SceneDelegate support (#57717) Jul 28, 2026
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Jul 28, 2026
Summary:
Pull Request resolved: react#57717

Update the RNTester and HelloWorld JS layers for SceneDelegate-based window resizing and app lifecycle behavior.

Changelog:
[iOS][Changed] - Update RNTester and HelloWorld for SceneDelegate lifecycle behavior

Test Plan:
- Verify Dimensions updates after resizing the RNTester window.
- Verify the HelloWorld app renders with the SceneDelegate bootstrap.
- `arc f`
- `arc lint`

Reviewed By: javache

Differential Revision: D113758227

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Jul 28, 2026
Summary:
Pull Request resolved: react#57717

Update the RNTester and HelloWorld JS layers for SceneDelegate-based window resizing and app lifecycle behavior.

Changelog:
[iOS][Changed] - Update RNTester and HelloWorld for SceneDelegate lifecycle behavior

Test Plan:
- Verify Dimensions updates after resizing the RNTester window.
- Verify the HelloWorld app renders with the SceneDelegate bootstrap.
- `arc f`
- `arc lint`

Reviewed By: javache

Differential Revision: D113758227

Pulled By: cipolleschi
Summary:
Pull Request resolved: react#57700

Add SceneDelegate lifecycle support to React Native iOS while retaining the AppDelegate path for backwards compatibility.

Update linking, window resolution, bootstrap APIs, RNTester, HelloWorld, and generated API snapshots for scene-based applications.

Changelog:
[iOS][Added] - Add SceneDelegate lifecycle support

Test Plan:
- `buck2 build --flagfile fbsource//fbobjc/mode/buck2/linux --config fbobjc.react_native_debug=development --flagfile fbsource//fbobjc/mode/iphonesimulator-arm64 --flagfile fbsource//fbobjc/mode/jest-coverage --config xplat.available_platforms=CXX,APPLE --config cxx.default_platform=iphonesimulator-arm64 --config user.sandcastle_build_mode=profile --config user.platform_flavor=iphonesimulator-arm64 //xplat/js/react-native-github/packages/rn-tester:RNTesterIOS`
- `xcodebuild -quiet -workspace RNTesterPods.xcworkspace -scheme RNTester -configuration Debug -destination "generic/platform=iOS Simulator" CODE_SIGNING_ALLOWED=NO build`
- `arc lint`
- Evaluate RNTester with the `RNTester` SceneDelegate scheme.
- Evaluate RNTester with the `RNTester (AppDelegate)` legacy scheme.
- Verify HelloWorld bootstrap and deep linking.

Reviewed By: javache

Differential Revision: D113758228

Pulled By: cipolleschi
Summary:
Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
Summary:
Pull Request resolved: react#57717

Update the RNTester and HelloWorld JS layers for SceneDelegate-based window resizing and app lifecycle behavior.

Changelog:
[iOS][Changed] - Update RNTester and HelloWorld for SceneDelegate lifecycle behavior

Test Plan:
- Verify Dimensions updates after resizing the RNTester window.
- Verify the HelloWorld app renders with the SceneDelegate bootstrap.
- `arc f`
- `arc lint`

Reviewed By: javache

Differential Revision: D113758227

Pulled By: cipolleschi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants