Skip to content

[visual testing] Make the platform checks neutral on differences - #60110

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
robhogan/visual-approved-checks-pass
Nov 19, 2026
Merged

meta-codesync[bot] merged 1 commit into
mainfrom
robhogan/visual-approved-checks-pass

Conversation

@robhogan

@robhogan robhogan commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

The Visual regression (android) and (ios) checks fail on any difference, and applying visual-change-approved only passes the Visual regression approval gate, so an approved PR still shows two red checks - eg #59787, where both platforms only differ by the new test it adds.

This makes the platform checks neutral when there are differences, so the gate is the only visual check that fails, and only until the differences are approved. None of the visual checks are required, and a neutral check doesn't fail a PR's overall status. Removing the label, or a push that changes the differences, fails the gate again as before.

Changelog: [Internal]

Test plan:
New unit test. Also ran the compare step's report against #59787's real report with the GitHub API mocked: both platform checks post neutral, and the gate posts failure without the label and success ("approved by @javache") with it.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 18, 2026
@robhogan
robhogan force-pushed the robhogan/visual-approved-checks-pass branch 2 times, most recently from 33171b2 to 6b51c22 Compare November 18, 2026 14:34
@robhogan robhogan changed the title [visual testing] Pass the platform checks once differences are approved [visual testing] Make the platform checks neutral on differences Nov 18, 2026
@meta-codesync

meta-codesync Bot commented Nov 18, 2026

Copy link
Copy Markdown

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D132905555.

@javache javache left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

The `Visual regression (android)` and `(ios)` checks failed on any difference, and only the `Visual regression approval` gate passes once a maintainer approves them, so an approved PR still showed two failing checks. The platform checks now report differences as neutral, and the gate is the only visual check that fails until they're approved.

Changelog: [Internal]
@robhogan
robhogan force-pushed the robhogan/visual-approved-checks-pass branch from 6b51c22 to 40e4509 Compare November 18, 2026 19:11
@meta-codesync
meta-codesync Bot merged commit 7564317 into main Nov 19, 2026
99 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @robhogan in 7564317

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants