Skip to content

Type argument for ensureInstance in the structuredClone test (#60131) - #60131

Merged
meta-codesync[bot] merged 1 commit into
react:mainfrom
panagosg7:export-D132764250
Nov 18, 2026
Merged

meta-codesync[bot] merged 1 commit into
react:mainfrom
panagosg7:export-D132764250

Conversation

@panagosg7

@panagosg7 panagosg7 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

ensureInstance(clonedErrors[0], TypeError) in structuredClone-itest.js leaves T underconstrained under Flow's new type-argument inference (experimental.implicit_instantiation_walk), which does not solve T from Class<T> against TypeError. The explicit <TypeError> is what the current inference picks, so the call checks the same in both.

Changelog: [Internal]


landed-with-radar-review

Differential Revision: D132764250

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2026
@meta-codesync

meta-codesync Bot commented Nov 18, 2026

Copy link
Copy Markdown

@panagosg7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D132764250.

…#60131)

Summary:

`ensureInstance(clonedErrors[0], TypeError)` in `structuredClone-itest.js` leaves `T` underconstrained under Flow's new type-argument inference (`experimental.implicit_instantiation_walk`), which does not solve `T` from `Class<T>` against `TypeError`. The explicit `<TypeError>` is what the current inference picks, so the call checks the same in both.

Changelog: [Internal]

___

landed-with-radar-review

Differential Revision: D132764250
@meta-codesync meta-codesync Bot changed the title Type argument for ensureInstance in the structuredClone test Type argument for ensureInstance in the structuredClone test (#60131) Nov 18, 2026
@meta-codesync
meta-codesync Bot merged commit 5a14634 into react:main Nov 18, 2026
58 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @panagosg7 in 5a14634

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants