Repository navigation
Type argument for ensureInstance in the structuredClone test (#60131) - #60131
Merged
Merged
Conversation
|
@panagosg7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D132764250. |
…#60131) Summary: `ensureInstance(clonedErrors[0], TypeError)` in `structuredClone-itest.js` leaves `T` underconstrained under Flow's new type-argument inference (`experimental.implicit_instantiation_walk`), which does not solve `T` from `Class<T>` against `TypeError`. The explicit `<TypeError>` is what the current inference picks, so the call checks the same in both. Changelog: [Internal] ___ landed-with-radar-review Differential Revision: D132764250
ensureInstance in the structuredClone testensureInstance in the structuredClone test (#60131)
panagosg7
force-pushed
the
export-D132764250
branch
from
November 18, 2026 22:06
dadd9fd to
8985f38
Compare
Collaborator
|
This pull request was successfully merged by @panagosg7 in 5a14634 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ensureInstance(clonedErrors[0], TypeError)instructuredClone-itest.jsleavesTunderconstrained under Flow's new type-argument inference (experimental.implicit_instantiation_walk), which does not solveTfromClass<T>againstTypeError. The explicit<TypeError>is what the current inference picks, so the call checks the same in both.Changelog: [Internal]
landed-with-radar-review
Differential Revision: D132764250