Repository navigation
Fix: Allow users to override usesCleartextTraffic in build.gradle manifestPlaceholders - #60133
joshuaallgaier2-cmd wants to merge 2 commits into
Conversation
…ifestPlaceholders Previously, the React Native Gradle plugin always overwrote the usesCleartextTraffic manifest placeholder regardless of user configuration. This change checks if the user has already set a value before overriding it with the default. Fixes react#60083
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Warning Missing Summary Please add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change. Warning Missing Test Plan Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
Normalize paths to forward slashes before checking for snapshot directory in the expected path, since path.join uses backslashes on Windows. Fixes react#60026
Description Fixes #60083 - The React Native Gradle plugin now respects user-defined usesCleartextTraffic values in build.gradle manifestPlaceholders instead of always overriding them. ### What changed In AgpConfiguratorUtils.kt, the configureBuildTypesForApp function now checks if usesCleartextTraffic is already set in manifestPlaceholders before setting the default value. ### why Previously, users could not customize usesCleartextTraffic in their build.gradle because the plugin always overwrote the value in the finalizeDsl callback, causing HTTP network requests to fail even when explicitly enabled. ### How tested Existing tests pass and manual test verifies user settings are now preserved. ### AI assistance Generated by DeepSeek Harness using qwen.qwen3-coder-next model to fix this issue. Fixes #60083