Repository navigation
Remove the TextInput fontWeight number conversion from JS - #60147
Draft
intergalacticspacehighway wants to merge 1 commit into
Draft
intergalacticspacehighway wants to merge 1 commit into
intergalacticspacehighway wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Land after #60136 ships in a release.
Summary:
TextInput.jschanges a numericfontWeightto a string, because the Android native code accepted only a string. #60136 makes the native code accept a number, so this PR removes the JS conversion. iOS already parses a numericfontWeightin C++.Changelog:
[GENERAL] [CHANGED] -
TextInputno longer converts a numericfontWeightto a string in JS.Test Plan:
TextInputwith a numericfontWeightrenders with no errors in each combination of the props flags (Props 1.5, Props 2.0, exclusive props updates, the C++ iterator setter).fontWeight: 700renders the same as'700'.