Add DynamicAccessedMembers attributes to BindingListEx methods#1087
Open
daniel-lerch wants to merge 1 commit into
Open
Add DynamicAccessedMembers attributes to BindingListEx methods#1087daniel-lerch wants to merge 1 commit into
daniel-lerch wants to merge 1 commit into
Conversation
Collaborator
|
So, the failing test is the one that makes sure that any changes to the public API surface go through an extra step of verification. There's 2 text files under DynamicData.Tests/API that track the "verified" version of the API surface, which are what the test compares against to detect changes. If you're running on Windows, you should be able to run the API test in VS, and when it fails, it'll launch an instance of WinMerge that'll let you merge the changes it detects into the "verified" file. Otherwise, you'll have to diff the generated files against the verified files manually, and marge the changes in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enables
IsAotCompatibleand fixes the few remaining warnings (resolves #1086). By enabling this flag, warning newly introduced in future .NET versions should become visible once new target frameworks are being added.Notes to reviewers:
net8.0target framework because Visual Studio 2026 did not allow me to build the project with duplicate target frameworks.DynamicallyAccessedMemberTypes.Allfor annotatingBindingListExwhich is not exactly the same asTypeDescriptor.AllMembersAndInterfaceswhich is being used byBindingList<T>internally. However, that special value is internal and verbose to replicate in a way compatible with various .NET versions.