chore: harden external links and clean auth flow#1480
Open
ranjiGT wants to merge 3 commits intorecodehive:gh-pagesfrom
Open
chore: harden external links and clean auth flow#1480ranjiGT wants to merge 3 commits intorecodehive:gh-pagesfrom
ranjiGT wants to merge 3 commits intorecodehive:gh-pagesfrom
Conversation
Updated the incorrect YouTube URL for the Pair Extraordinaire badge video tutorial in githubbadge.html. Old URL: https://youtu.be/BNKSlT8jLQ0 New URL: https://www.youtube.com/watch?v=ZoNO_e8PjiM Co-authored-by: sanjay-kv <sanjay-kv@users.noreply.github.com>
- add rel="noopener noreferrer" for target="_blank" links\n- remove duplicate GitHub auth handler call in login flow\n- remove sensitive OAuth debug logs\n- fix githubbadge HTML cleanup (duplicate CSS include, extra </td>, duplicate FA include) Co-authored-by: sanjay-kv <sanjay-kv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sanjay-kv This PR is for some security fixes and cleaning up the repo, requesting a check!
#1480
Summary
This PR improves the GitHub badge page and applies security and cleanup fixes across the project.
What changed
rel="noopener noreferrer"to external links that usetarget="_blank".Why this change
Testing done
Notes
Co-author has been added in commit metadata:
Co-authored-by: sanjay-kv sanjay-kv@users.noreply.github.com