[PHPUnit60] Add DoesNotPerformAssertions attribute directly and skip traits - #765
Merged
Merged
Conversation
…traits in AddDoesNotPerformAssertionToNonAssertingTestRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to
AddDoesNotPerformAssertionToNonAssertingTestRector:1) Add the attribute directly, when it exists
If
PHPUnit\Framework\Attributes\DoesNotPerformAssertionsis available (PHPUnit 10+), the attribute is added instead of the annotation. Projects on older PHPUnit keep getting the docblock annotation.final class SomeTest extends TestCase { - public function test() + #[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions] + public function test() { $nothing = 5; } }Previously this always produced:
2) Skip traits
A trait method has no owning class, so there is no way to tell whether the class using it asserts elsewhere. Adding the attribute there can silence a real assertion check.