Repository navigation
[Php80] Skip mixed and untyped calls in TernaryToNullsafeCoalesceRector - #8531
Merged
TomasVotruba merged 1 commit intoOct 6, 2026
Merged
Conversation
TypeCombinator::containsNull() is false for MixedType, so a call returning mixed (or declaring no return type) was rewritten to "?->... ?? $fallback", and a null result started falling through to the fallback. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
LGTM |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
TernaryToNullsafeCoalesceRectorno longer rewrites a ternary to?->… ?? $fallbackwhen the call or property fetch returnsmixedor has no declared type. Only calls whose type excludesnullfor sure are rewritten now.Why?
The guard
shouldSkipCoalesceFallback()relied onTypeCombinator::containsNull(), which returnsfalseforMixedType— it only detects an explicitNullTypeor a union containing it. Anullreturned by such a call then fell through to the fallback, changing behavior:This broke
InterceptorPipeline::handle()in spiral/framework (spiral/framework#1307).Checklist
rules-tests/Php80suite and PHPStan on the rule run locally