Skip to content

Add login button#83

Open
galactic-magpie wants to merge 7 commits intoadd-share-buttonfrom
add-login-effect
Open

Add login button#83
galactic-magpie wants to merge 7 commits intoadd-share-buttonfrom
add-login-effect

Conversation

@galactic-magpie
Copy link
Copy Markdown
Contributor

Closes #

💸 TL;DR

  • Adds a 'login' button to the logged out win page
  • Updates devvit dependencies to 0.12.22.next in order to use the login effect
  • Fixes a bug with logged out play: when the logged out user wins and logs in to 'save' that win, the game shows "Nice try" until the user refreshes the page again. It still briefly flashes (I'm looking into why) but automatically updates to the win page without needing additional page refresh.

📜 Details

Design Doc

Jira
https://reddit.atlassian.net/browse/DX-10922

🧪 Testing Steps / Validation

Tested on a local testing subreddit: https://www.reddit.com/r/jde0804_dev/

*NOTE: test app jde-hotandcold uses a local json of words instead of the supabase DB used in prod. If you're testing, the known words are:

"win",
"lose",
"craft",
"make",
"triangle",
"apple",
"stone",
"paint",
"shape",
"color",
"start",
"subreddit",
"retry"
hotandcold.login.effect.mov

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@galactic-magpie galactic-magpie changed the title Add login effect Add login button May 5, 2026
* add 'share' button to top menu

* add 'share' button to logged out win page

* add share button to logged in win page too

* fix button padding & size

* update share text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant