feat(vm-storage-labeling): add storage volume labeling role#5
Closed
stevefulme1 wants to merge 11 commits into
Closed
feat(vm-storage-labeling): add storage volume labeling role#5stevefulme1 wants to merge 11 commits into
stevefulme1 wants to merge 11 commits into
Conversation
Move from openshift_virtualization_migration repo — this is day 2 ops functionality for labeling PVCs/DataVolumes on existing VMs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
…-ansible manage deps/commands
sabre1041
reviewed
May 5, 2026
sabre1041
left a comment
There was a problem hiding this comment.
@stevefulme1 This looks good. Only comment is related to my prior comment whether there was a requirement to scope to either a namespace or by labels. In the vm_collect role, a namespace is only required when names are specified. Not a blocking item. However, it provides alignment to other capabilities within the collection
In addition, would you be able to review the conflicts in the test-requirements.txt file?
- Resolve test-requirements.txt merge conflict (remove bare tox) - Make namespace optional, required only when names are specified, aligning with vm_collect role pattern per reviewer request - Use omit for namespace in k8s_info queries to support cluster-wide PVC labeling when no namespace is provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm_storage_labelingrole and playbook to apply labels, annotations, and descriptive names to PersistentVolumeClaims (PVCs) and DataVolumes at the OCP levelMoved from
Originally submitted as redhat-cop/openshift_virtualization_migration#15 — relocated here as this is day 2 ops functionality (managing storage on existing VMs), not migration logic.
FQCN updated from
infra.openshift_virtualization_migrationtoinfra.openshift_virtualization_ops.Test plan
yamllintpassesansible-lint --offlinepasses production profile🤖 Generated with Claude Code