Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
|
@rrelledge the screenshot for the "create a database" step is really large. You could scale it down to half that size I think |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| - Reduce infrastructure costs by combining high-speed RAM with cost-efficient flash storage | ||
|
|
||
| {{<note>}} | ||
| Flex does not replace long-term data persistence. For workloads that require durability and recovery across restarts or failures, use Redis persistence features like [AOF (Append-Only File)]({{< relref "/operate/oss_and_stack/management/persistence#append-only-file" >}}), [RDB snapshots]({{< relref "/operate/oss_and_stack/management/persistence#snapshotting" >}}), or both. For more information, see [Database persistence]({{< relref "/operate/rs/databases/configure/database-persistence" >}}). |
There was a problem hiding this comment.
I suggest adding a dedicated "What Flex isn't" section with the wording similar to the doc: https://docs.google.com/document/d/1PuFejCooJpy_gs0MoM5Pf9MLS46x6gcNUmzYfPjIHik/edit?disco=AAABz_t08H0&tab=t.0
There was a problem hiding this comment.
This info is already included in a note in https://redis.io/docs/staging/DOC-6284/operate/rs/flex/#when-to-use-flex:
Note:
Flex does not replace long-term data persistence. For workloads that require durability and recovery across restarts or failures, use Redis persistence features like AOF (Append-Only File), RDB snapshots, or both. For more information, see Database persistence.
There was a problem hiding this comment.
I agree the content is indeed present, In my opinion we should have an explicit and dedicated "When not to use Flex" - up to you, resolving this comment :)
|
Thank you this is looking great |
|
|
||
| You can add more shards to expand dataset capacity while maintaining the existing RAM-to-flash ratio. Throughput capacity also typically increases as a result of additional shards and infrastructure. This strategy is recommended when the dataset size and traffic are expected to grow together. | ||
|
|
||
| Before you increase the dataset capacity and add shards, you need to add more RAM and vCPUs to handle the increased number of shards. |
There was a problem hiding this comment.
Let's make it more explicit:
This increases capacity without adding CPU or RAM but may reduce RAM hit-rate and increase p99 latency; monitor metrics before and after the change.
There was a problem hiding this comment.
This suggestion contradicts the statement: "you need to add more RAM and vCPUs to handle the increased number of shards."
There was a problem hiding this comment.
It's saying the same thing and adding the "monitor metrics before and after".
There was a problem hiding this comment.
I think I'm still a little confused since your original comment said "without adding CPU or RAM," but the rough draft document said "you need to add more RAM and vCPUs".
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
Some minor suggestions/questions but otherwise LGTM.
|
|
||
| ## Flex and Auto Tiering | ||
|
|
||
| Flex replaces [Auto Tiering]({{< relref "/operate/rs/7.22/databases/auto-tiering" >}}) (formerly known as Redis on Flash). Redis Software selects the implementation based on your Redis version: |
There was a problem hiding this comment.
Dead link in staging but the path looks OK. Maybe it resolves in the full build?
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
5 participants
Note
Low Risk
Low risk because changes are documentation-only, primarily new pages and link/wording updates; main risk is broken or inconsistent cross-references/aliases in the docs site.
Overview
Introduces a new
Flex databasesdocs section (content/operate/rs/flex) with overview, get-started, deployment planning, and scaling guidance.Updates the existing
databases/flashpages to de-emphasize “Redis Flex” branding (rename to “Flex”), add banner callouts directing readers to the new Flex section, and refresh links/next-steps (including updated Kubernetes and metrics references) while keeping Auto Tiering information as legacy context.Reviewed by Cursor Bugbot for commit 85ee885. Bugbot is set up for automated code reviews on this repo. Configure here.