Conversation
…URLs The authenticator repository moved out of the personal namespace, so the exact-URL pin and its checker pointed at a location the project no longer owns. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
A reader comparing this page against the current authenticator release finds a different plugin, a different runtime and a different registry, with no statement of which generation the lab deploys or why. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two problems with how this repository names the eSignet authenticator it deploys.
versions.env, and the checker that enforces them, still pointed atgithub.com/jeremi/esignet-relay-authenticator. The repository has moved togithub.com/registrystack/esignet-relay-authenticator, so the pins named a location the project no longer owns.docs/esignet.mddescribes the v0.2.0 profile: a Java plugin JAR built intomosipid/esignet-with-plugins, authenticating against Registry Relay. The upstream authenticator's v0.3.0 release replaced that with a Go provider compiled into eSignetv2.0.0-beta.1that reads a Base Registry Engine registry through one governed lookup carrying a Registry Mint token, and ships an OCI image tar rather than a JAR. A reader comparing the page against the current release finds a different plugin, a different runtime and a different registry, with nothing saying which generation the lab runs.This lab deploys no Base Registry Engine, and v0.3.0 defers Relay support, so it cannot move to v0.3.0. The fix is to say so, not to rewrite the flow.
What changed
versions.env: the three authenticator URLs repointed to theregistrystack/namespace. The tag, asset names and SHA-256 pins are unchanged.scripts/check-registry-stack-release-pin.pyandscripts/test_registry_stack_release_pin.py: the same repoint, test fixture first.docs/esignet.md: a paragraph after the opening naming the v0.3.0 generation, what it changed, and why the lab stays on the v0.2.0 JAR profile the rest of the page describes.No compose file, image pin, scope, credential or route changed. Nothing here touches auth, authorization, credential issuance, disclosure, redaction, audit, replay, config trust or signing behaviour: the authenticator artifact identity (tag plus digest) is byte for byte what it was, only the host path is corrected. I verified the
registrystack/URLs resolve and that the published.sha256matchesversions.env.Checks
Run:
just generate: passjust lint: pass (ruff,check-fiction.sh,check-config-secrets.py,check-image-pins.py,hosted-image-manifest.py inventory,check-runtime-topology.py,check-registry-stack-release-pin.py,check-signer-public-keys.py, portal and homesvelte-checkat 0 errors, 0 warnings)just test: 254 Python tests, 1 failure, see below, plus the generator, scenario-runner, portal and home suitesSkipped, no running stack in this environment:
just smokeandjust reviewPre-existing failure, unrelated to this change:
scripts/test_smoke_programme_acceptance.py::test_all_programme_and_generic_refusal_checks_passasserts the captured stderr is empty, and aResourceWarning: unclosed databasesurfaces inside itsredirect_stderrblock. It reproduces on this branch's merge base with these commits reverted, and the test passes when run on its own, so it is an ordering-dependent flake from an unclosedsqlite3connection in the generator being collected during that capture window. Flagging rather than fixing, since it is outside this change.