Conversation
divolgin
approved these changes
May 5, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
replicated channel delete(and its aliasrm) to accept either a channel name or a channel ID, matching the behavior of other channel commands such asinspectandrelease demote.Problem
Previously,
replicated channel delete <name>failed witharchive app channel: Not found.because the command passed the raw argument directly to the archive API as an ID, with no name resolution.Solution
Uses the existing
GetChannelByNamehelper (already used bychannel inspect) to resolve the input to a channel before callingArchiveChannel. This provides:Changes
cli/cmd/channel_rm.go:rm CHANNEL_ID_OR_NAMEchannel name or ID is requiredGetChannelByNameresolution beforeArchiveChannel