Migrate to v13 - #1320
Conversation
|
oops |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f168802652
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @scope("globalThis") | ||
| external filename: option<string> = "__filename" |
There was a problem hiding this comment.
__filename from globalThis
In Node CommonJS, __filename is injected as a module-local binding rather than exposed as globalThis.__filename; in ESM it is absent entirely. Consequently, this example always takes the None branch even in CommonJS, incorrectly reporting a non-Node environment. Use an actual global object property for this example or explain that module-local identifiers cannot be accessed through globalThis.
Useful? React with 👍 / 👎.
2 participants
This branch was created to test the experimental server rescript-lang/rescript#8425