Skip to content

Vendor Flow parser 0.267.0 - #8587

Merged
cknitt merged 2 commits into
rescript-lang:masterfrom
cknitt:codex/vendor-flow-parser-0.267
Aug 28, 2026
Merged

Vendor Flow parser 0.267.0#8587
cknitt merged 2 commits into
rescript-lang:masterfrom
cknitt:codex/vendor-flow-parser-0.267

Conversation

@cknitt

@cknitt cknitt commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

  • vendor the Flow parser version currently used by ReScript (0.267.0) from the ReScript Flow fork
  • include the required Flow Sedlex fork and collection helpers
  • replace the external flow_parser package dependency with private Dune libraries
  • document the exact upstream commit, included sources, adaptations, and licenses
  • add focused parser tests to verify JavaScript, JSX, comments, and parse errors

This is the first, deliberately conservative step toward unblocking newer OCaml versions. It keeps the parser and compiler behavior unchanged while bringing the currently used sources under ReScript's control. A later PR can upgrade the vendored parser independently.

Related to #8567.

Signed-off-by: Christoph Knittel <ck@cca.io>
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.91%. Comparing base (0f66af5) to head (7361545).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8587   +/-   ##
=======================================
  Coverage   75.90%   75.91%           
=======================================
  Files         474      475    +1     
  Lines       63000    63033   +33     
=======================================
+ Hits        47822    47853   +31     
- Misses      15178    15180    +2     
Files with missing lines Coverage Δ
tests/ounit_tests/ounit_flow_parser_tests.ml 93.93% <ø> (ø)
tests/ounit_tests/ounit_tests_main.ml 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Aug 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8587

@rescript/belt

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/belt@8587

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8587

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8587

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8587

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8587

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8587

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8587

commit: 7361545

@cknitt

cknitt commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e73ecedbe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread compiler/flow_parser/parser/object_parser.ml
Comment thread compiler/flow_parser/parser/flow_ast_utils.ml
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt
cknitt enabled auto-merge (squash) August 28, 2026 06:13
@cknitt
cknitt merged commit afdaaa8 into rescript-lang:master Aug 28, 2026
29 checks passed
@cknitt
cknitt deleted the codex/vendor-flow-parser-0.267 branch August 29, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants