fix(button): add px unit to mso-text-raise on Outlook spacer#3591
Conversation
|
@yashs33244 is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: e34fe66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fix mso-text-raise CSS property to include required 'px' unit for Outlook compatibility. Changes are isolated to a single line in the Button component and its test snapshots, with no logic or architectural impact.
Re-trigger cubic
dielduarte
force-pushed
the
fix/button-mso-text-raise-unit
branch
from
9264b52 to
1ae885c
Compare
The left [if mso] spacer interpolated the raise value as a bare number (mso-text-raise:18), which Outlook treats as invalid CSS, so the spacer was not raised to match the button label. The sibling label already emits the unit via React; append px here too.
dielduarte
force-pushed
the
fix/button-mso-text-raise-unit
branch
from
1ae885c to
030859b
Compare
commit: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dielduarte
force-pushed
the
fix/button-mso-text-raise-unit
branch
from
030859b to
e34fe66
Compare
What
Buttonbuilds the left Outlook padding spacer as a raw string and interpolates the vertical raise without a unit:That renders
mso-text-raise:18, which Outlook treats as invalid (a non-zero length needs a unit), so the hair-space spacer isn't raised. The sibling button label sets the same property through a React style object (msoTextRaise: pxToPt(paddingBottom)), which React serializes with a unit (mso-text-raise:9px), so the two were inconsistent.Fix
Append
pxto the spacer's raise value so it matches the label (mso-text-raise:18px). One-line change; the 18:9 ratio is unchanged. Updated the three affected inline snapshots (mso-text-raise:18->18px, and two:0->:0px).Summary by cubic
Fixes the Outlook padding spacer in
Buttonby adding thepxunit tomso-text-raiseon the left[if mso]spacer. Outlook now applies the raise correctly, matching the label.pxonmso-text-raise(18->18px,0->0px).Written for commit e34fe66. Summary will update on new commits.