fix: remove unnecessary code which prevents onBlock to be invoked#153
Open
gnekoz wants to merge 1 commit into
Open
fix: remove unnecessary code which prevents onBlock to be invoked#153gnekoz wants to merge 1 commit into
gnekoz wants to merge 1 commit into
Conversation
|
Please merge this |
|
@rmariuzzo Would it be possible to merge these changes to address the issue? I’d really appreciate it :) thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue #152
The deleted line seems to be unnecessary and it will fail when the browser is blocking the popup/tab opening.
This will result in the
onBlockcallback to never be called