[RDF] Always write nominal columns in Snapshot with variations.#21246
Merged
hageboeck merged 2 commits intoApr 28, 2026
Conversation
Test Results 22 files 22 suites 3d 9h 49m 23s ⏱️ For more details on these failures, see this check. Results for commit d7414e6. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
RDF_snapshot_twoVariations
branch
from
dab901e to
e6d8632
Compare
hageboeck
requested review from
dpiparo,
martamaja10,
pcanal and
vepadulano
as code owners
Before, the nominal columns were omitted from the output if their filter didn't pass. This is, however, insufficient, because if at least two variations are run, (some of) the nominal columns might still be in use. The tests have been updated to reflect the fact that the nominal columns are not zeroed out.
hageboeck
force-pushed
the
RDF_snapshot_twoVariations
branch
2 times, most recently
from
545855a to
899088e
Compare
vepadulano
approved these changes
Apr 27, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks for the fix! This will enable more use cases for the Snapshot with variations 👍 Changes LGTM, I left a couple of comments in the test only
hageboeck
force-pushed
the
RDF_snapshot_twoVariations
branch
from
899088e to
ce5b8f8
Compare
When two variations are run, e.g. x_var and y_var, and the computation
graph uses both x and y, the pairs {x, y_var} and {x_var, y} need to be
visible in the output file. This means that the nominal columsn always
need to be written, even if {x, y} would not pass the filter.
hageboeck
force-pushed
the
RDF_snapshot_twoVariations
branch
from
ce5b8f8 to
d7414e6
Compare
Member
Author
|
/backport to 6.40 |
|
Preparing to backport PR #21246 to branch 6.40 requested by hageboeck |
|
This PR has been backported to branch 6.40: #22089 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the nominal columns were omitted from the output if their filter
didn't pass. This is, however, insufficient, because if at least two
variations are run, (some of) the nominal columns might still be in use.
One example is this setup:
In every variation universe, a Filter on
xandyis used. If one writes downwhat the value of the nominal and varied columns should be in the snapshot,
one gets conflicting requirements for the nominal columns if one keeps zeroeing
the invalid columns to save space as was done before.
Imagine a dataset where only the
var0variation passes the filter. One gets:var0passedThe problem is the column
y:In the nominal universe, it shouldn't be present, but since it's used as an unvaried column also in the
var0universe, it must be in the output dataset. The same argument can be made forxifvar1were to pass. Therefore, the nominal columns must remain visible in the output dataset as soon as any filter in any variation passes.The tests have been updated to reflect the fact that the nominal columns are not zeroed out.