[padpainter] handle text size in correspondent painters#22088
Merged
Conversation
Depending from kind of output PS/VirtualX/GL either pixel size or relative size is used. While TAttText should not care - move conversion to correspondent TPadPainter class. In ROOT7 one can move handling of text size down to concrete implementation like TGX11 or TSVG. Now keep as is for backward compatibility.
While TGLPadPainter uses own font handles, one also can implement text extension measuring
Used for latex - so provide it
Otherwise TGCocoa.h header cannot be used Hide X11Atoms.h from TGCocoa.h while it is only used internally by TGCococa
Directly map gVirtualX->ClearWindowW() functionality, while there is tiny difference with already existing ClearDrawable() method. This method only used in TCanvas::Build().
This was referenced Apr 28, 2026
Test Results 22 files 22 suites 3d 14h 4m 50s ⏱️ For more details on these failures, see this check. Results for commit 68c001f. |
couet
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normal
TPadPainterrequire pixel size, butTPadPainterPSexpects relative units.Move this difference from
TAttTextto correspondent painter classes.Implement new text extension routines for
TGLPadPainter.While it uses own
ftgl-based text rendering - also let it provide text extension/ascent/descent metrics.Adjust
TGCocoabuild - move necessary includes to public include directory, otherwise "TGCocoa.h" is not usable.