Skip to content

[config] Add TGeometry link flag only when available - #22941

Merged
vepadulano merged 2 commits into
root-project:masterfrom
vepadulano:root-config-fix
Jul 30, 2026
Merged

[config] Add TGeometry link flag only when available#22941
vepadulano merged 2 commits into
root-project:masterfrom
vepadulano:root-config-fix

Conversation

@vepadulano

Copy link
Copy Markdown
Member

#22845 broke usage of root-config in -Dgeom=off builds, by unconditionally appending TGeometry to the list of link flags. Use the same pattern of RDataFrame to make the addition conditional to the availability based on the CMake configuration.

@vepadulano
vepadulano requested a review from hageboeck July 28, 2026 09:02
@vepadulano vepadulano self-assigned this Jul 28, 2026
@vepadulano
vepadulano requested a review from dpiparo as a code owner July 28, 2026 09:02

@hageboeck hageboeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 14h 57m 13s ⏱️
 3 881 tests  3 881 ✅ 0 💤 0 ❌
79 943 runs  79 943 ✅ 0 💤 0 ❌

Results for commit a303e96.

♻️ This comment has been updated with latest results.

Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
@vepadulano
vepadulano merged commit c08a2bc into root-project:master Jul 30, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants