[ntuple] Encapsulate RNTupleAnchorS3 fields - #22952
Merged
silverweed merged 1 commit intoJul 30, 2026
Merged
Conversation
JasMehta08
requested review from
bellenot,
jblomer and
silverweed
as code owners
July 29, 2026 04:50
silverweed
reviewed
Jul 29, 2026
JasMehta08
force-pushed
the
s3-anchor-encapsulation
branch
2 times, most recently
from
July 29, 2026 13:23
5a847f7 to
7bc062b
Compare
Test Results 23 files 23 suites 3d 18h 3m 33s ⏱️ Results for commit 7db692a. ♻️ This comment has been updated with latest results. |
JasMehta08
force-pushed
the
s3-anchor-encapsulation
branch
from
July 30, 2026 05:13
7bc062b to
7db692a
Compare
Contributor
Author
|
@silverweed, all the tests were passing, but there was a small error with the clang format, I have updated the code, I think now that should also pass as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
(Is a part of the GSoC 2026 project
S3 Backend for RNTuple.)Changes or fixes:
RNTupleAnchorS3from astructwith public fields to aclasswith private fields and public getters.RPageSinkS3as afriendso the write path can set fields directly.CreateFromJSONusing test-local helpers (MakeAnchorJson,MakeAnchor) and read fields through getters.nlohmann_jsonandxxHashto the S3 test target for anchor construction and checksum computation in tests.Checklist:
This PR is a follow up of #22819