fix(deps): update dependency reduce-configs to v2#58
Conversation
renovate
Bot
force-pushed
the
renovate/reduce-configs-2.x
branch
2 times, most recently
from
0bbff75 to
4ef2ac2
Compare
renovate
Bot
force-pushed
the
renovate/reduce-configs-2.x
branch
from
4ef2ac2 to
00513c3
Compare
📝 WalkthroughWalkthroughThis PR updates the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 31: reduceConfigs v2 returns a Promise but applyCSSMinimizer in
src/index.ts treats it synchronously and passes a Promise into
CssMinimizerWebpackPlugin; change applyCSSMinimizer to be async, await
reduceConfigs(...) to produce mergedOptions, and update all call sites (notably
the api.modifyBundlerChain(...) callback) to await applyCSSMinimizer(chain,
CHAIN_ID, options) so CssMinimizerWebpackPlugin receives the resolved
CssMinimizerPluginOptions rather than a Promise.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 21ad1315-de54-495d-bc81-cfef9c9151e2
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
| "dependencies": { | ||
| "css-minimizer-webpack-plugin": "^8.0.0", | ||
| "reduce-configs": "^1.1.2" | ||
| "reduce-configs": "^2.0.1" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find all usages of reduceConfigs and applyCSSMinimizer to assess migration scope
echo "=== Searching for reduceConfigs usage ==="
rg -n --type=ts --type=js -A 3 -B 3 '\breduceConfigs\s*\('
echo ""
echo "=== Searching for applyCSSMinimizer calls to identify what needs async updates ==="
rg -n --type=ts --type=js -A 3 -B 3 '\bapplyCSSMinimizer\s*\('
echo ""
echo "=== Checking for other reduce-configs APIs that might be affected ==="
rg -n --type=ts --type=js 'from ["\']reduce-configs["\']'Repository: rstackjs/rsbuild-plugin-css-minimizer
Length of output: 1289
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== package.json (lines around type + reduce-configs) ==="
if [ -f package.json ]; then
# Print a small window around "reduce-configs" and "type"
rg -n '"type"' package.json
rg -n '"reduce-configs"' package.json
echo "--- context around reduce-configs ---"
rg -n -C 5 '"reduce-configs"' package.json
echo "--- context around type ---"
rg -n -C 5 '"type"' package.json
else
echo "package.json not found"
fi
echo
echo "=== src/index.ts (applyCSSMinimizer + reduceConfigs usage) ==="
if [ -f src/index.ts ]; then
rg -n 'export function applyCSSMinimizer|reduceConfigs\s*\(' src/index.ts
echo "--- lines 1-130 ---"
sed -n '1,130p' src/index.ts
else
echo "src/index.ts not found"
fi
echo
echo "=== Search for reduce-configs import(s) and other APIs ==="
# Robustly search for any reduce-configs named imports/usage
rg -n --type=ts --type=js 'from\s+["'\'']reduce-configs["'\'']' .
rg -n --type=ts --type=js '\breduceConfigs(WithContext|AsyncWithContext|MergeContext)?\b' srcRepository: rstackjs/rsbuild-plugin-css-minimizer
Length of output: 3715
🌐 Web query:
reduce-configs v2.0.0 reduceConfigs return type Promise
💡 Result:
In version 2.0.0 and later of the reduce-configs package, the reduceConfigs function returns a Promise [1][2]. This change was introduced to make configuration reducers asynchronous, allowing them to handle both synchronous and asynchronous operations [1]. As part of this update, the API was simplified by removing the older synchronous/asynchronous split, meaning that reduceConfigs now consistently returns a promise regardless of whether the provided configuration callbacks return a value, void, or a promise [1].
Citations:
Critical: reduceConfigs v2 is async, but applyCSSMinimizer uses it synchronously.
reduce-configs@^2.0.1 makes reduceConfigs return Promise<T>, but src/index.ts assigns it directly to mergedOptions in a non-async applyCSSMinimizer and passes that promise into CssMinimizerWebpackPlugin options.
Required fix: make applyCSSMinimizer async, await reduceConfigs, and await the call site.
export async function applyCSSMinimizer(
chain: RspackChain,
CHAIN_ID: ChainIdentifier,
options: PluginCssMinimizerOptions = {},
): Promise<void> {
const mergedOptions: CssMinimizerPluginOptions = await reduceConfigs({
initial: {
minify: CssMinimizerWebpackPlugin.cssnanoMinify,
minimizerOptions: getCssnanoDefaultOptions(),
},
config: options.pluginOptions,
});
chain.optimization
.minimizer(CHAIN_ID.MINIMIZER.CSS)
.use(CssMinimizerWebpackPlugin as Rspack.RspackPluginInstance, [
mergedOptions,
])
.end();
}Then update the call inside api.modifyBundlerChain(async ...):
await applyCSSMinimizer(chain, CHAIN_ID, options);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 31, reduceConfigs v2 returns a Promise but
applyCSSMinimizer in src/index.ts treats it synchronously and passes a Promise
into CssMinimizerWebpackPlugin; change applyCSSMinimizer to be async, await
reduceConfigs(...) to produce mergedOptions, and update all call sites (notably
the api.modifyBundlerChain(...) callback) to await applyCSSMinimizer(chain,
CHAIN_ID, options) so CssMinimizerWebpackPlugin receives the resolved
CssMinimizerPluginOptions rather than a Promise.
This PR contains the following updates:
^1.1.2→^2.0.1Release Notes
rstackjs/reduce-configs (reduce-configs)
v2.0.1Compare Source
What's Changed
Full Changelog: rstackjs/reduce-configs@v2.0.0...v2.0.1
v2.0.0Compare Source
Breaking Changes
reduceConfigsandreduceConfigsWithContextnow returnPromise<T>.reduceConfigsAsyncWithContext,reduceConfigsMergeContexthas been removed.What's Changed
48b55a0by @renovate[bot] in #40Full Changelog: rstackjs/reduce-configs@v1.1.2...v2.0.0
Configuration
📅 Schedule: (in timezone Asia/Shanghai)
* 0-3 1,15 * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.