perf(fmt): optimize Yuku parser selection - #312
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
5354dea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10c93ece.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-perf-yuku-parser.rstack-cli.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84731a982f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes Yuku language selection extension-driven so regular TypeScript files no longer scan their full contents with a JSX regex or retry unrelated grammars. It also masks comments in a single chunked pass instead of rebuilding the complete source for each comment, while preserving JS JSX, TS/TSX, declaration-file, and module/CommonJS behavior.
Performance
Mean isolated CPU time per real repository corpus:
Comment-mask output matched for all 2,202 parsed Rsbuild files and 3,613 parsed Rspack files. These are isolated CPU benchmarks; end-to-end formatting gains are smaller because Prettier work dominates and
rs fmtformats files in parallel.