Ignore nonpositive console size overrides - #159
Merged
Conversation
nobu
force-pushed
the
codex/console-size-positive
branch
2 times, most recently
from
September 4, 2026 01:44
8791bed to
88b16a8
Compare
nobu
force-pushed
the
codex/console-size-positive
branch
from
September 4, 2026 02:15
88b16a8 to
e94292b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept
LINESandCOLUMNSfallbacks only when they are positive integers.Reproduction
Focused external models set each variable to negative text. Current code accepts a negative nonzero dimension; the candidate falls back to 25x80.
Verification
Compatibility
Positive overrides remain unchanged; invalid nonpositive dimensions now use the existing defaults. Prepared with AI-assisted source review; no repository tests were changed.