Optimize Lrama parser generation performance - #794
Open
ydah wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized performance optimizations with preserved semantics (plus slightly safer handling in a few edge paths) and include appropriate cache invalidation.
Pull request overview
This PR focuses on reducing Lrama parser-generation time by avoiding repeated linear scans and repeated regexp compilation during grammar parsing and lookahead computation.
Changes:
- Speed up lookahead computation by iterating only existing lookback relations and caching rule lookup by
id. - Speed up state transitions by caching transitions in a
symbol.number -> transitionhash and using it forState#transition. - Speed up lexing by precompiling frequently used regex patterns and reducing repeated instance-variable access in
lex_c_code.
File summaries
| File | Description |
|---|---|
| sig/generated/lrama/state.rbs | Adds RBS types for the new @transitions_by_symbol_number cache and accessor. |
| sig/generated/lrama/lexer.rbs | Adds RBS constants for the precompiled lexer regex patterns. |
| lib/lrama/states.rb | Optimizes compute_la to avoid scanning all rules and to reduce repeated work per state. |
| lib/lrama/state.rb | Adds a transition lookup cache keyed by symbol number and uses it in State#transition. |
| lib/lrama/lexer.rb | Precompiles regexes for symbol/percent-token scanning and refactors lex_c_code to reduce repeated work. |
Review details
- Files reviewed: 3/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimize Lrama parser generation performance.
parse.y