Skip to content

Fix IELR follow-kernel item filtering #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ydah wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix IELR follow-kernel item filtering #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/lrama/states.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,9 +661,8 @@ def compute_follow_kernel_items
base_function = compute_goto_bitmaps
Digraph.new(set, relation, base_function).compute.each do |goto, follow_kernel_items|
state = goto.from_state
state.follow_kernel_items[goto] = state.kernels.map {|kernel|
[kernel, Bitmap.to_bool_array(follow_kernel_items, state.kernels.count)]
}.to_h
bools = Bitmap.to_bool_array(follow_kernel_items, state.kernels.count)
state.follow_kernel_items[goto] = state.kernels.zip(bools).to_h
end
end

Expand Down
18 changes: 18 additions & 0 deletions spec/lrama/states_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1876,6 +1876,24 @@ class go to state 5
end

describe '#compute_ielr' do
it 'stores a boolean for each follow kernel item' do
path = "integration/ielr.y"
y = File.read(fixture_path(path))
grammar = Lrama::Parser.new(y, path).parse
grammar.prepare
grammar.validate!
states = Lrama::States.new(grammar, Lrama::Tracer.new(Lrama::Logger.new))
states.compute
states.compute_ielr

values = states.states.flat_map do |state|
state.follow_kernel_items.values.compact.flat_map(&:values)
end

expect(values).to include(false)
expect(values).to all(satisfy("be a boolean") { |value| value == true || value == false })
Comment on lines +1893 to +1894
end

it 'recompute states' do
path = "integration/ielr.y"
y = File.read(fixture_path(path))
Expand Down