Conversation
Dir.for_fd takes ownership of the descriptor, so passing dir.fileno left two unclosed Dirs owning the same fd once dir was closed. Their finalizers later closed whatever file reused that number, which made FileTestSingletonTest fail with Errno::EBADF on ruby/ruby's macOS CI. Give each call its own descriptor and close the returned Dir. https://github.com/ruby/ruby/actions/runs/36829284827 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileTestSingletonTeststarted failing withErrno::EBADF: Bad file descriptor @ fptr_finalize_flushin ruby/ruby'stest-bundled-gemson macOS. The cause isDirSingletonTest#test_for_fd, which runs before it.Dir.for_fdtakes ownership of the descriptor, but the test passeddir.filenoand never closed the returned Dirs. Afterdirwas closed, two unclosed Dirs still owned the same number. When GC finalized them,closedirclosed whatever file had reused that number.This gives each call a fresh descriptor from
IO.sysopenand closes the returned Dir. I confirmed locally that no Dir owning the old descriptor remains after the test.https://github.com/ruby/ruby/actions/runs/36829284827
Generated with Claude Code