Document Ferrum's Docker container mode - #323
Merged
Merged
Conversation
Updated Docker usage instructions for Cuprite driver to include Ferrum's container mode and clarified the no-sandbox option usage.
Updated instructions for using Chrome in Docker with Cuprite, emphasizing Ferrum's container mode and removing redundant options.
Clarify usage of Ferrum's container mode and browser options.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-sandboxexample with Ferrum'sdockerize: trueoption
use its sandbox
Why
Ferrum 0.17.2 introduced the
dockerize: trueoption inrubycdp/ferrum#561.
The same change updated Ferrum's Docker documentation to use
dockerize: trueinstead of configuring
no-sandboxmanually.Cuprite's browser inherits from
Ferrum::Browserand passes its driver optionsto Ferrum, so the option can be used directly in the Cuprite driver
configuration. The current Cuprite README still shows the older manual option
and implies that disabling the sandbox is required for every Docker setup.
This change aligns the Cuprite documentation with Ferrum's current container
API while making it clear that the browser sandbox should remain enabled when
the container supports it.
References
Testing
Documentation-only change. No automated tests were run.