Repository navigation
Conversation
Every script runs the new way: keyword arguments are named parameters, a function declaration takes positional arguments only, promises are awaited, a script returns the value of its last statement, and Node#evaluate returns nodes and dates. A script timeout is always bounded, by timeout: or the page's timeout. Removes Runtime::Legacy, Utils::Deprecate, evaluate_async, evaluate_func, evaluate_on, FERRUM_JS_API and FERRUM_DEPRECATION_WARNINGS, along with the scanner parts only the old API needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #673 for 0.21: every script runs the new way, the old API and its switches are gone.
Node#evaluatereturns nodes and datestimeout:or the page's timeoutRemoved:
Runtime::Legacy,Utils::Deprecate,#evaluate_async,#evaluate_func,#evaluate_on,FERRUM_JS_APIandFERRUM_DEPRECATION_WARNINGS, plus the scanner parts only the old API needed. The upgrade notes are indocs/13-javascript.md#upgrading-to-021.