Add coverage for Learning hour topics and types#6841
Merged
compwron merged 1 commit intorubyforgood:mainfrom Apr 14, 2026
Merged
Add coverage for Learning hour topics and types#6841compwron merged 1 commit intorubyforgood:mainfrom
compwron merged 1 commit intorubyforgood:mainfrom
Conversation
Closes rubyforgood#6840 `learning_hour_topics_controller.rb` and `learning_hour_types_controller.rb` do not have any coverage. Let's add coverage to them so we catch any errors in the future.
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
stefannibrasil
commented
Apr 9, 2026
|
|
||
| def learning_hour_topic_params | ||
| params.require(:learning_hour_topic).permit(:name, :active).merge( | ||
| params.require(:learning_hour_topic).permit(:name).merge( |
Contributor
Author
There was a problem hiding this comment.
active is not a column for learning hour topics.
compwron
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Closes #6840
What changed, and why?
learning_hour_topics_controller.rbandlearning_hour_types_controller.rbdo not have any coverage. Let's add coverage tothem so we catch any errors in the future.