Fix learning_hour test for date that is not in the future#6865
Open
alanparmenter wants to merge 1 commit intorubyforgood:mainfrom
Open
Fix learning_hour test for date that is not in the future#6865alanparmenter wants to merge 1 commit intorubyforgood:mainfrom
alanparmenter wants to merge 1 commit intorubyforgood:mainfrom
Conversation
Pass a datetime, not a String, for comparison in occurred_at_not_in_future.
alanparmenter
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
Contributor
Author
|
More relevant screenshots: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
No Issue. Small fix.
What changed, and why?
Pass a datetime, not a String, for comparison in
occurred_at_not_in_future. String formatting withstrftimewas inappropriate for testing this function.casa/app/models/learning_hour.rb
Lines 41 to 47 in 10fb1a9
How is this tested? (please write rspec and jest tests!) 💖💪
bundle exec rspec ./spec/models/learning_hour_spec.rbScreenshots please :)
Before:
After:
Feelings gif (optional)