Repository navigation
Fix case group membership org check for groups saved with a new org - #7326
Merged
Merged
Conversation
When a group and its cases are saved together with a new org, the org is saved through the group first and the case's casa_org_id is still nil, so the id comparison rejected a valid group (bulk_court_dates_spec:59). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one red rspec example on main,
spec/requests/bulk_court_dates_spec.rb:59: Validation failed: Case group memberships is invalid.CaseGroupMembershipchecks that the case and the group belong to the same org. It comparedcasa_org_ids. When a group and its cases are built together with a brand-new org, as that spec's factory does, the org gets saved through the group first, so the case'scasa_org_idis stillnilwhen the membership is validated. Comparing the org records handles that, and is the same as comparing ids once both are persisted.Tests: every spec file that mentions
case_group, 62 examples, 0 failures, including the previously failingbulk_court_dates_spec.🤖 Generated with Claude Code