qnx: Add missing definitions for io-sock

[lambinoo]

I'm currently working on getting socket2 to compile for QNX8 networking stack. This PR adds some missing network related structs and constants.

[tgross35]

Looks reasonable enough to me but the target maintainers should review/test. Cc @flba-eb @gh-tr @jonathanpallant @japaric

@rustbot label +S-waiting-on-maintainer

View changes since this review

[tgross35]

Please put these links into the commit message, rather than in comments

[lambinoo]

Updated! Also fixed the the in_addr fields to crate::in_addr since that's what the rest of the file is using

[rustbot]

⚠️ Warning ⚠️

• The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

  • b539bb3

  You can start a rebase with the following commands:

  $ # rebase
  $ git pull --rebase https://github.com/rust-lang/libc.git main
  $ git push --force-with-lease
  

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[tgross35]

Looks spurious

View changes since the review

[tgross35]

Also this is labled "fix" but this is just an API addition. For future reference we don't use conventional commits but instead use scoping, makes it much easier to get a changelog (no need to change it's just an FYI)

[tgross35]

LGTM, just waiting on a target maintainer to confirm

View changes since this review

[jonathanpallant]

I would strongly advise against linking to the FreeBSD headers in the commit message. The only place to check these constants is in QNX SDP 8.0 and/or its online documentation, because whilst it might be based on FreeBSD, QNX could have changed any of these constants to suit their needs.

Using target/qnx/usr/include/netinet/in.h in my copy of QNX SDP 8, I have verified:

• ip_mreqn
• ip_mreq_source
• TCP_KEEPIDLE
• TCP_KEEPINTVL
• TCP_KEEPCNT
• IP_RECVTOS
• IP_ADD_SOURCE_MEMBERSHIP
• IP_DROP_SOURCE_MEMBERSHIP

[lambinoo]

Should I remove the references to freeBSD then from the commit message? Mostly wanted to link to publicly available headers, but it's true that the SDP is the only source of truth here.

[jonathanpallant]

Also, the ip_mreqn and ip_mreq_source structures don't exist in QNX SDP 7.1 from what I can see, so these should probably be excluded from those targets.

Uh, scratch that. I didn't have io-sock installed. They look the same in QNX SDP 7.1.

[lambinoo]

Also, the ip_mreqn and ip_mreq_source structures don't exist in QNX SDP 7.1 from what I can see, so these should probably be excluded from those targets.

Uh, scratch that. I didn't have io-sock installed. They look the same in QNX SDP 7.1.

Yeah, they should be in usr/include/io-sock/netinet/in.h. From my understand, QNX is backporting anything on the io-sock side from 8 to 7.1. So they should be the same most if not all the time.

[lambinoo]

Removed any references to FreeBSD from the commit message

[tgross35]

Thanks Jonathan for reviewing