Bump railroad-dependency; themed syntax diagrams - #2328
Open
lukaslueg wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the
railroad-dependency from 0.3.7 to 0.3.9, which fixes some minor layout issues. It also introduces support for the themes used bymdBook, instead of relying on just two globallight/darkthemes.Some global CSS rules were (re-) moved to support multiple themes. The
railroad-specific stylesheets are no longer put into the page's content if that page doesn't include a diagram, shaving some bytes off. The test was added to ensure that the stylesheets' selectors (which are defined upstream) don't ever leak outside thesvg.railroad-namespace; this wasn't a problem before, just for future-compatibility.I built and visually inspected the reference locally, and it seems fine to me.
Please notice that I couldn't exactly figure out the licensing status of the
Rust,Coal,NavyandAyuthemes; out of an abundance of caution, the stylesheets include a reference to the original definitions from which these themes were derived, which is included in the final CSS. De facto the palettes seem to be ubiquitous around the web.Please notice that an LLM was used to assist in these changes.
Light
Rust
Coal
Navy
Ayu