Repository navigation
Conversation
rustbot
added
S-waiting-on-review
1 of 8 tasks
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
August 6, 2026 08:53
34238f6 to
6bf460d
Compare
bjorn3
reviewed
Aug 6, 2026
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
August 6, 2026 10:20
6bf460d to
ce5650d
Compare
57 tasks
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
August 17, 2026 09:28
ce5650d to
89fe5bb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
August 17, 2026 14:13
89fe5bb to
ab764ef
Compare
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
August 19, 2026 15:26
ab764ef to
6c38dd1
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
August 21, 2026 18:46
6c38dd1 to
c78fabd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
November 9, 2026 20:12
c78fabd to
d2e4e3e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
November 9, 2026 21:28
d2e4e3e to
63b7618
Compare
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
November 9, 2026 21:35
63b7618 to
3d0b511
Compare
RalfJung
commented
Nov 9, 2026
|
|
||
| let diag = format!( | ||
| "mixing target features will cause an ABI mismatch in crate `{local_crate}`" | ||
| "mixing target features may cause an ABI mismatch in crate `{local_crate}`" |
Member
Author
There was a problem hiding this comment.
This is mostly a drive-by fix -- not all target feature mixing will cause ABI trouble, so I used "may" in the new message and updated the old one to match.
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
November 9, 2026 21:45
3d0b511 to
813d3b0
Compare
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
llvm-target-feature-codegen-backends
branch
from
November 10, 2026 07:39
813d3b0 to
c334451
Compare
folkertdev
reviewed
Nov 12, 2026
| "mixing codegen backends while using backend-specific target features may cause an ABI mismatch in crate `{local_crate}`" | ||
| ); | ||
| let mut diag = tcx.dcx().struct_err(diag); | ||
| diag.help("this crate has `-Zllvm-target-features` set, which means different codegen backends could interpret the target features differently, or ignore them entirely"); |
Contributor
There was a problem hiding this comment.
Suggested change
| diag.help("this crate has `-Zllvm-target-features` set, which means different codegen backends could interpret the target features differently, or ignore them entirely"); | |
| diag.help("this crate has `-Zllvm-target-feature` set, which means different codegen backends could interpret the target features differently, or ignore them entirely"); |
Probably grep to see if this happened anywhere else.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Finishes the implementation of #157753 by ensuring that we don't mix codegen backends when using backend-specific target features (as other backends would ignore those).
r? @folkertdev
Cc @davidtwco @azhogin I hope I am using target modifiers correctly :D